fix midpoint

Reviewed-on: #9

Simulations/MassSpringSystemSimulator.cpp

@@ -1,21 +1,13 @@
 #include "MassSpringSystemSimulator.h"
+#include <stdio.h>
 
 MassSpringSystemSimulator::MassSpringSystemSimulator()
 {
-	m_iTestCase = 0;
-	m_fMass = 10;
-	m_fStiffness = 40;
-	int m_iIntegrater = 0;
-
-	auto first = addMassPoint(Vec3(0, 0, 0), Vec3(-1, 0, 0), true);
-	auto second = addMassPoint(Vec3(0, 2, 0), Vec3(1, 0, 0), true);
-	addSpring(first, second, 1.0);
-
 }
 
 const char* MassSpringSystemSimulator::getTestCasesStr()
 {
-	return "Euler,LeapFrog,Midpoint";
+	return "Demo1,Demo2,Demo3,Demo4";
 }
 
 void MassSpringSystemSimulator::initUI(DrawingUtilitiesClass* DUC)
@@ -23,13 +15,14 @@ void MassSpringSystemSimulator::initUI(DrawingUtilitiesClass* DUC)
 	this->DUC = DUC;
 	switch (m_iTestCase)
 	{
-	case 0:break;
-	case 1:
-	
-		break;
-	case 2:
-		break;
-	default:break;
+		case 0:
+			break;
+		case 1:
+			break;
+		case 2:
+			break;
+		default:
+			break;
 	}
 }
 
@@ -38,10 +31,11 @@ void MassSpringSystemSimulator::reset()
 	m_mouse.x = m_mouse.y = 0;
 	m_trackmouse.x = m_trackmouse.y = 0;
 	m_oldtrackmouse.x = m_oldtrackmouse.y = 0;
+
+	springs.clear();
+	masspoints.clear();
 }
 
-
-
 void MassSpringSystemSimulator::drawFrame(ID3D11DeviceContext* pd3dImmediateContext)
 {
 	
@@ -68,24 +62,91 @@ void MassSpringSystemSimulator::drawFrame(ID3D11DeviceContext* pd3dImmediateCont
 void MassSpringSystemSimulator::notifyCaseChanged(int testCase)
 {
 	m_iTestCase = testCase;
+	system("cls");
+	reset();
+
 	switch (m_iTestCase)
 	{
-	case 0:
-		cout << "Euler !\n";
+	case 0: {
+		cout << "Demo 1 !\n";
+		setMass(10);
+		setStiffness(40);
 
-//simulateTimestep(1);
+		int first = addMassPoint(Vec3(0, 0, 0), Vec3(-1, 0, 0), true);
+		int second = addMassPoint(Vec3(0, 2, 0), Vec3(1, 0, 0), true);
+
+		addSpring(first, second, 1);
+		cout << "\t -- INITIAL --\n";
+		printSpring(springs.at(0));
+		cout << "--------------------------------------------------" << std::endl;
+
+		//calculate Euler for one step and print results
+		setIntegrator(EULER);
+		cout << "\n\n\t -- EULER RESULT --\n";
+		simulateTimestep(1);
+		printSpring(springs.at(0));
+
+		cout << "--------------------------------------------------" << std::endl;
+
+		reset();
+		first = addMassPoint(Vec3(0, 0, 0), Vec3(-1, 0, 0), true);
+		second = addMassPoint(Vec3(0, 2, 0), Vec3(1, 0, 0), true);
+
+		addSpring(first, second, 1);
+
+		//calculate Midpoint for one step and print results
+		setIntegrator(MIDPOINT);
+		cout << "\n\n\t -- MIDPOINT RESULT --\n";
+		simulateTimestep(1);
+		printSpring(springs.at(0));
+		break;
+	}
+	
+	case 1: {
+		cout << "Demo 2 !\n";
+		reset();
+		int first = addMassPoint(Vec3(0, 0, 0), Vec3(-1, 0, 0), true);
+		int second = addMassPoint(Vec3(0, 2, 0), Vec3(1, 0, 0), true);
+		addSpring(first, second, 1.0);
+
+		cout << "\t -- INITIAL --\n";
+		printSpring(springs.at(0));
+
+		cout << "--------------------------------------------------" << std::endl;
+
+		//calculate Euler for a timestep of 0.005 and print results
+		setIntegrator(EULER);
+		cout << "\n\n\t -- EULER RESULT--\n";
+		simulateTimestep(0.005);
+		printSpring(springs.at(0));
 
 		break;
-	case 1:
-		break;
-	case 2:
-		cout << "Midpoint \n";
-		//m_iNumSpheres = 100;
-		//m_fSphereSize = 0.05f;
-		break;
+	}
 
+	case 2: {
+		cout << "Demo 3 !\n";
+		reset();
+		int first = addMassPoint(Vec3(0, 0, 0), Vec3(-1, 0, 0), true);
+		int second = addMassPoint(Vec3(0, 2, 0), Vec3(1, 0, 0), true);
+		addSpring(first, second, 1.0);
+
+		cout << "\t -- INITIAL --\n";
+		printSpring(springs.at(0));
+
+		cout << "--------------------------------------------------" << std::endl;
+
+		//calculate Midpoint for a timestep of 0.005 and print results
+		setIntegrator(MIDPOINT);
+		cout << "\n\n\t -- MIDPOINT RESULT --\n";
+		simulateTimestep(0.005);
+		printSpring(springs.at(0));
+		break;
+	}
+	case 3: {
+		cout << "Demo 4 !\n";
+		break;
+	}
 	default:
-		//cout << "Demo4 !\n";
 		break;
 	}
 }
@@ -113,29 +174,29 @@ void MassSpringSystemSimulator::externalForcesCalculations(float timeElapsed)
 
 }
 
-
-
 void MassSpringSystemSimulator::simulateTimestep(float timeStep)
 {
 	//update current setup for each frame
-	switch (m_iTestCase) {
-	case 0:
-		//update the masspoint
-		cout << "Euler \n";
-		Euler(0, 1, 0, timeStep);
+	for (size_t i = 0; i < springs.size(); i++) {
+		auto sp = springs.at(i);
+		if (!sp.isValid())
+		{
+			springs.erase(springs.begin() + i);
+			continue;
+		}
 
-		break;
-	case 1:
-		break;
+		if (m_iIntegrator == EULER) {
 
-	case 2:cout << "midpoint \n";
-		Midpoint(0, 1, timeStep);
-		break;
+			Euler(sp, timeStep);
+		}
+		else if (m_iIntegrator == MIDPOINT) {
+			Midpoint(sp, timeStep);
+		}
+		else if (m_iIntegrator == LEAPFROG) {
+			//TODO: Add Leapfrog
+		}
 
-	default: break;
 	}
-
-	//Euler(0, 1, 0, timeStep);
 }
 
 void MassSpringSystemSimulator::onClick(int x, int y)
@@ -218,17 +279,13 @@ void MassSpringSystemSimulator::applyExternalForce(Vec3 force)
 	//eine Vorstellung: for all Masspoints, update force
 }
 
-int MassSpringSystemSimulator::LengthCalculator(Vec3 position1, Vec3 position2) {
-
-	Vec3 PosVector = position1 - position2;
+float MassSpringSystemSimulator::LengthCalculator(Vec3 vector) 
+{
 	//wurzel aus Vektor
-	int length = sqrt(pow(PosVector.x, 2) + pow(PosVector.y, 2) + pow(PosVector.z, 2));
-	
+	float length = sqrt(vector.x * vector.x + vector.y * vector.y + vector.z * vector.z);
 	return length;
 }
 
-
-
 Vec3 MassSpringSystemSimulator::calculatePositionTimestepEuler(Vec3 oldPosition, float timestep, Vec3 velocity)
 {
 	return oldPosition + timestep * velocity;
@@ -244,73 +301,81 @@ Vec3 MassSpringSystemSimulator::calculateAcceleration(Vec3 force, float mass)
 	return force / mass;
 }
 
-void MassSpringSystemSimulator::Midpoint(int index1, int index2, float timestep) {
+void MassSpringSystemSimulator::Midpoint(Spring& spring, float timestep) {
 	//here some implementation about Midpoint
-	auto massPoint1 = masspoints.at(index1);
-	auto massPoint2 = masspoints.at(index2);
-	//old position
-	auto mp = massPoint1->position;
-	auto mp2 = massPoint2 ->position;
-	//old Velocity
-	auto mOld_v = massPoint1->velocity;
-	auto m2Old_v = massPoint1->velocity;
+	auto massPoint1 = spring.mp1.lock();
+	auto massPoint2 = spring.mp2.lock();
 
-	Vec3 PosVector = mp - mp2;
+	Vec3 PosVector = massPoint1->position - massPoint2->position;
 	//Abstand ausrechnen
-	int d = LengthCalculator(mp, mp2);
+	float length = sqrtf(PosVector.x * PosVector.x + PosVector.y * PosVector.y + PosVector.z * PosVector.z);
 	//normalize
-	Vec3 PosNorm1 = PosVector / d;
-	Vec3 PosNorm2 = -1 * PosNorm1;
-
-	Vec3 Force = -m_fStiffness * (d - springs.at(0).initialLength) * PosNorm1;
-	Vec3 Force2 = -1 * Force;
-
-	Vec3 oldAcc = calculateAcceleration(Force,m_fMass);
-	Vec3 oldAcc2 = calculateAcceleration(Force2, m_fMass);
+	Vec3 normal = PosVector / length;
 
 	//Midpoint calculator
-	//Pos of Midstep
-	Vec3 PosOfMidstep = mp + 0.5 * timestep * mOld_v;
-	Vec3 PosOfMidstep2 = mp2 + 0.5 * timestep * m2Old_v;
-	//Vel at Midstep
-	Vec3 VelAtMidstep = mOld_v + 0.5 * timestep * oldAcc;
-	Vec3 VelAtMidstep2 = m2Old_v + 0.5 * timestep * oldAcc2;
+	std::tuple<Vec3, Vec3> midpointStep1 = MidPointHalfStep(timestep * .5, spring, massPoint1->position, massPoint1->velocity, normal, length);
+	std::tuple<Vec3, Vec3> midpointStep2 = MidPointHalfStep(timestep * .5, spring, massPoint2->position, massPoint2->velocity, -normal, length);
 
-	Vec3 NewPos = mp + timestep * VelAtMidstep;
-	Vec3 NewPos2 = mp2 + timestep * VelAtMidstep2;
+	Vec3 newPosVector = std::get<0>(midpointStep1) - std::get<0>(midpointStep2);
+	float newLength = sqrtf(newPosVector.x * newPosVector.x + newPosVector.y * newPosVector.y + newPosVector.z * newPosVector.z);
+	Vec3 newNormal = newPosVector / newLength;
 
-	Vec3 NewVel = mOld_v + timestep * oldAcc;
-	Vec3 NewVel2 = m2Old_v + timestep * oldAcc2;
-	cout << NewPos;
-	cout << NewVel;
-	massPoint1->position = NewPos;
-	massPoint1->velocity = NewVel;
-	massPoint2->position = NewPos2;
-	massPoint2->velocity = NewVel2;
+	std::tuple<Vec3, Vec3> midpoint1 = MidPointStep(timestep, spring, massPoint1->position, massPoint1->velocity, std::get<1>(midpointStep1), newNormal, newLength);
+	std::tuple<Vec3, Vec3> midpoint2 = MidPointStep(timestep, spring, massPoint2->position, massPoint2->velocity, std::get<1>(midpointStep2), -newNormal, newLength);
+	
+	massPoint1->position = std::get<0>(midpoint1);
+	massPoint1->velocity = std::get<1>(midpoint1);
+	massPoint2->position = std::get<0>(midpoint2);
+	massPoint2->velocity = std::get<1>(midpoint2);
 }
 
-void MassSpringSystemSimulator::Euler(int index1, int index2, int indexSpring, float timestep)
+std::tuple<Vec3, Vec3> MassSpringSystemSimulator::MidPointHalfStep(double timestep, const Spring& spring, Vec3 position, Vec3 velocity, Vec3 normal, double length)
 {
+	return MidPointStep(timestep, spring, position, velocity, velocity, normal, length);
+}
+
+
+std::tuple<Vec3, Vec3> MassSpringSystemSimulator::MidPointStep(double timestep, const Spring& spring, Vec3 position, Vec3 oldVelo,Vec3 velocity, Vec3 normal, double length)
+{
+	auto force = -m_fStiffness * (length - spring.initialLength) * normal;
+	auto acc = calculateAcceleration(force, m_fMass);
+	auto pos = position + timestep * velocity;
+	auto vel = oldVelo + timestep * acc;
+	return std::tuple<Vec3, Vec3>(pos, vel);
+}
+
+void MassSpringSystemSimulator::Euler(Spring& spring, float timestep)
+{
+	auto massPoint1 = spring.mp1.lock();
+	auto massPoint2 = spring.mp2.lock();
+
 	//take old position and send to calculatePositionTimestepEuler
-	auto mp = masspoints.at(index1);
-	auto mp2 = masspoints.at(index2);
-	Vec3 PosVector = mp->position - mp2->position;
+	auto PosVector = massPoint1->position - massPoint2->position;
 	auto lengthVector = sqrt(PosVector.x * PosVector.x + PosVector.y * PosVector.y + PosVector.z * PosVector.z);
 	auto normalized = PosVector / lengthVector;
 
 	// Actual Calculation
 	// Force of spring is -k * (l - L) * normalizedVector [for P2 we can take -F1)
-	auto force = -m_fStiffness * (lengthVector - springs.at(0).initialLength) * normalized;
+	auto force = -m_fStiffness * (lengthVector - spring.initialLength) * normalized;
 	auto foreP2 = -1 * force;
-	auto veloc = calculateVelocityTimestepEuler(mp->velocity, timestep, calculateAcceleration(force, 10.));
-	auto pos = calculatePositionTimestepEuler(mp->position, timestep, veloc);
+	auto veloc = calculateVelocityTimestepEuler(massPoint1->velocity, timestep, calculateAcceleration(force, m_fMass));
+	auto pos = calculatePositionTimestepEuler(massPoint1->position, timestep, massPoint1->velocity);
 
-	auto veloc2 = calculateVelocityTimestepEuler(mp2->velocity, timestep, calculateAcceleration(foreP2, 10.));
-	auto pos2 = calculatePositionTimestepEuler(mp2->position, timestep, veloc2);
+	auto veloc2 = calculateVelocityTimestepEuler(massPoint2->velocity, timestep, calculateAcceleration(foreP2, m_fMass));
+	auto pos2 = calculatePositionTimestepEuler(massPoint2->position, timestep, massPoint2->velocity);
 
 	// Update Positions and Velocity
-	mp->position = pos;
-	mp->velocity = veloc;
-	mp2->position = pos2;
-	mp2->velocity = veloc2;
+	massPoint1->position = pos;
+	massPoint1->velocity = veloc;
+
+	massPoint2->position = pos2;
+	massPoint2->velocity = veloc2;
+}
+
+void MassSpringSystemSimulator::printSpring(const Spring& spring)
+{
+	auto mp1 = spring.mp1.lock();
+	auto mp2 = spring.mp2.lock();
+	printf("Masspoint 1:\nPosition: %s \nVelocity: %s\n\n", mp1->position.toString().c_str(), mp1->velocity.toString().c_str());
+	printf("Masspoint 2:\nPosition: %s \nVelocity: %s\n", mp2->position.toString().c_str(), mp2->velocity.toString().c_str());
 }

Simulations/MassSpringSystemSimulator.h

@@ -39,13 +39,17 @@ public:
 	Vec3 getVelocityOfMassPoint(int index);
 	void applyExternalForce(Vec3 force);
 
-	void Midpoint(int index1, int index2, float timestep);
-	int LengthCalculator(Vec3 position1, Vec3 position2);
+	void Midpoint(Spring& spring, float timestep);
+	std::tuple<Vec3, Vec3> MidPointHalfStep(double timestep, const Spring& spring, Vec3 position, Vec3 velocity, Vec3 normal, double length);
+	std::tuple<Vec3, Vec3> MassSpringSystemSimulator::MidPointStep(double timestep, const Spring& spring, Vec3 position, Vec3 oldVelo, Vec3 velocity, Vec3 normal, double length);
+	float LengthCalculator(Vec3 vector);
 
 	Vec3 calculatePositionTimestepEuler(Vec3 oldPosition, float timestep, Vec3 veloctiy);
 	Vec3 calculateVelocityTimestepEuler(Vec3 oldVelocity, float timestep, Vec3 acceleration);
 	Vec3 calculateAcceleration(Vec3 acceleration, float mass);
-	void Euler(int index1, int index2, int indexSpring, float timestep);
+	void Euler(Spring& spring, float timestep);
+
+	void printSpring(const Spring& spring);
 	
 	// Do Not Change
 	void setIntegrator(int integrator) {